Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing columns to gwctl get policies #2808

Conversation

jongwooo
Copy link
Member

What type of PR is this?

/kind feature
/area gwctl
/cc @gauravkghildiyal

What this PR does / why we need it:

Add missing columns to gwctl get policies.

Output Columns Description Visibility
NAME Name of the Policy
KIND The kind of policy in the form <kind.group>
TARGET NAME Name of the resource the policy applies to
TARGET KIND The kind of target resource in the form
POLICY TYPE Type of policy (Inherited or Direct)
AGE Age of the Policy

Which issue(s) this PR fixes:

Fixes #2807

Does this PR introduce a user-facing change?:

Add missing columns to `gwctl get policies`

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. area/gwctl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 23, 2024
@jongwooo jongwooo force-pushed the add-missing-columns-to-gwctl-get-policies branch from 38ef347 to b1b4a05 Compare February 26, 2024 08:06
@gauravkghildiyal
Copy link
Member

/assign

@jongwooo jongwooo marked this pull request as draft February 27, 2024 00:11
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 27, 2024
@jongwooo
Copy link
Member Author

I'll work on injecting the fack clock during testing.

@jongwooo jongwooo force-pushed the add-missing-columns-to-gwctl-get-policies branch 2 times, most recently from 411c91d to 6aa4377 Compare March 4, 2024 06:15
@jongwooo jongwooo marked this pull request as ready for review March 4, 2024 06:16
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 4, 2024
Copy link
Member

@gauravkghildiyal gauravkghildiyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jongwooo! Just one small request and rest all good :) Thank you for the patience.

gwctl/pkg/printer/policies.go Show resolved Hide resolved
Signed-off-by: Jongwoo Han <jongwooo.han@gmail.com>
@jongwooo jongwooo force-pushed the add-missing-columns-to-gwctl-get-policies branch from 6aa4377 to 4dcada0 Compare March 6, 2024 06:50
@gauravkghildiyal
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 6, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauravkghildiyal, jongwooo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2024
@k8s-ci-robot k8s-ci-robot merged commit ef4832a into kubernetes-sigs:main Mar 6, 2024
8 checks passed
@jongwooo jongwooo deleted the add-missing-columns-to-gwctl-get-policies branch March 6, 2024 07:14
hanxiaop pushed a commit to hanxiaop/gateway-api that referenced this pull request Mar 13, 2024
Signed-off-by: Jongwoo Han <jongwooo.han@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/gwctl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add missing columns to gwctl get policies
3 participants