Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conformance profiles renamed #3019

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

mlavacca
Copy link
Member

What type of PR is this?

/kind cleanup
/area conformance

What this PR does / why we need it:

The conformance profiles have been renamed to allow the addition of nwe mesh profiles. Furthermore, the MESH-GRPC conformance profile has been added.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

The conformance profiles have been renamed according to the following format: <GATEWAY|MESH>-<HTTP|GRPC|TLS>.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. area/conformance cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 24, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 24, 2024
@mlavacca
Copy link
Member Author

/cc @robscott @shaneutt

Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
Copy link
Member

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this works better for folks, seems fine. Thanks Mattia!

/cc @robscott for full review

@k8s-ci-robot
Copy link
Contributor

@shaneutt: GitHub didn't allow me to request PR reviews from the following users: for, full, review.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

If this works better for folks, seems fine. Thanks Mattia!

/cc @robscott for full review

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@shaneutt shaneutt added this to the v1.1.0 milestone Apr 24, 2024
@robscott
Copy link
Member

Thanks so much @mlavacca!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 24, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mlavacca, robscott, shaneutt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@robscott
Copy link
Member

/retest

@k8s-ci-robot k8s-ci-robot merged commit 2645468 into kubernetes-sigs:main Apr 24, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants