fix: change report API version #3153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/bug
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mlavacca The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
Thanks @mlavacca! LGTM once gofumpt check passes |
Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
mlavacca
force-pushed
the
fix-conformance-report-api-version
branch
from
c947146
to
947f3d6
Compare
It's fixed now, PTAL :) |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
BobyMCbobs
pushed a commit
to BobyMCbobs/kubernetes-sigs-gateway-api
that referenced
this pull request
Jul 10, 2024
Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
BobyMCbobs
pushed a commit
to BobyMCbobs/kubernetes-sigs-gateway-api
that referenced
this pull request
Jul 22, 2024
Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/area conformance
What this PR does / why we need it:
With the graduation of the conformance test suite we bumped the
ConformanceReportAPI to v1. However, we did not change theAPIVersionof the reports created by the suite accordingly. The result was that we were creating v1 reports with v1alpha1 set asAPIVersion. This PR fixes such a problem.Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: