Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: partial reports can be submitted #3179

Merged
merged 2 commits into from
Aug 9, 2024
Merged

docs: partial reports can be submitted #3179

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0fe7c9a
docs: reports rules updated
mlavacca Jul 2, 2024
3dce980
address comments
mlavacca Jul 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions conformance/reports/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ comply with the following rules:
- `mode`: it is the mode of the implementation used to run the tests. If different
from `default`, it must correspond to a specific setup of the implementation.
- Test result: in order to have a report valid to be accepted, all the profiles
need to have the `result` fields (core and extended) set to `success`. It means
that all the core conformance tests have been successfully run as well as all
the tests related to the supported extended features. No reports with partial
or failing results can be accepted.
need to have the `result` fields (core and extended) set to `success` or `partial`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like we probably need to include some guidelines for how we handle partial conformance results. Maybe it's sufficient to just say that they'll be displayed separately?

It means that all the core conformance tests have been successfully run or properly
skipped as well as all the tests related to the supported extended features. No
reports with failing results can be accepted.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's another reason for partial conformance - the tests may all pass, but the reproduction required some kind of additional unexpected steps.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I reworded this section to include this information