-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow the header based session persistence not to have AbsoluteTimeout #3215
fix: allow the header based session persistence not to have AbsoluteTimeout #3215
Conversation
/retest |
f382d4b
to
2e863ab
Compare
2e863ab
to
d46ae46
Compare
Thanks @sanposhiho! Will defer to @gcs278 on this one, but this looks correct to me. |
/assign @gcs278 |
Thanks! |
Good catch, I missed this with the initial revision, and thanks for the fix! |
/approve |
@robscott: once the present PR merges, I will cherry-pick it on top of release-1.1 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: robscott, sanposhiho The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks for the review, everyone. What's the rule around |
Thanks @sanposhiho! We automatically add holds on any PR that modifies a GEP because we require at least two approvals on those. We've met that criteria here, so let's get this merged. /hold cancel |
@robscott: new pull request created: #3221 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR scope out the header based session persistence from the validation
AbsoluteTimeout must be specified when cookie lifetimeType is Permanent
.See #3214.
Which issue(s) this PR fixes:
Fixes #3214
Does this PR introduce a user-facing change?: