Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GRPCRoute GEP to standard #3227

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Update GRPCRoute GEP to standard #3227

merged 1 commit into from
Jul 29, 2024

Conversation

xtineskim
Copy link
Contributor

GEP-1016 (GRPCRoute) was still marked as Experimental, even though it's been moved to standard since v1.1 🤯
What type of PR is this?

/kind bug
/kind cleanup
/kind documentation
/kind gep

What this PR does / why we need it:
Updates the GRPCRoute GEP to show it's standard
Also fixed a spacing issue where the sub bullet points were not rendering on the site

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. kind/gep PRs related to Gateway Enhancement Proposal(GEP) cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 29, 2024
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 29, 2024
@robscott
Copy link
Member

Good catch, thanks @xtineskim!

/lgtm
/approve
/hold cancel
/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 29, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 29, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: robscott, xtineskim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2024
@k8s-ci-robot k8s-ci-robot merged commit dbf5a17 into kubernetes-sigs:main Jul 29, 2024
8 checks passed
xtineskim added a commit to xtineskim/gateway-api that referenced this pull request Aug 8, 2024
@xtineskim
Update GRPCRoute GEP to standard (kubernetes-sigs#3227)
85e2e1c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikemorris mikemorris Awaiting requested review from mikemorris

@youngnick youngnick Awaiting requested review from youngnick

Assignees

@robscott robscott

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. kind/gep PRs related to Gateway Enhancement Proposal(GEP) lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xtineskim @robscott @k8s-ci-robot