-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GEP2257 Duration parsing #3271
GEP2257 Duration parsing #3271
Conversation
@xtineskim: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Added format tests, makeDuration func for duration testing
461df45
to
62b9397
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So first, many many many thanks for volunteering to write these, @xtineskim! 🙏 🙏 😁 I really appreciate it and it's lovely to see this arrive with comments and tests and everything!
I've left comments which are mostly pretty small things and, honestly, have been informed by writing the Rust version of this, and I'm going to comment rather than approve just to make sure we get other eyes on the FormatDuration
function. Many thanks again!! 🙂
bd51d3c
to
f10052f
Compare
f10052f
to
e6abec2
Compare
/approve Nice work! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a couple of minor comments, and I think I agree with @robscott about making all the formatters look roughly the same. Thanks for sticking with this!! 🙂
e9f7fdc
to
8692bfc
Compare
8692bfc
to
b7ca574
Compare
ffe8536
to
f36389e
Compare
Thanks @xtineskim! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: robscott, xtineskim, youngnick The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Per GEP 2257, adding duration utils for implementing GEP2257 duration format
What type of PR is this?
/kind feature
(not sure if this is the right kind for this 😅 )
What this PR does / why we need it:
Per GEP 2257 Duration formatting's next step to graduation is implementing parsers. Helping out with this push to standard channel 👍
Which issue(s) this PR fixes:
Fixes #
Related PRs:
Does this PR introduce a user-facing change?:
cc: @kflynn