Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conformance: Update the Gloo Gateway project's published 1.0.0 reports #3289

Conversation

timflannagan
Copy link
Contributor

What type of PR is this?

/area conformance

What this PR does / why we need it:

Updates the published 1.0.0 conformance reports for the Gloo Gateway project. This hasn't been updated in a while for any of the 1.17.x Gloo releases that added support for the k8s GW API. Additionally, this removes the stale 2.0.0-beta1 report that is no longer relevant.

Which issue(s) this PR fixes:

Fixes #

N/A.

Does this PR introduce a user-facing change?:

NONE

This commits updates the published 1.0.0 conformance suite
reports for the Gloo Gateway project.

Signed-off-by: timflannagan <timflannagan@gmail.com>
This commit removes the published v2.0.0-beta1 Gloo Gateway
conformance report. Previously, support for the Kubernetes
Gateway API integration in the solo-io/gloo repository was
done in a v2 feature branch and this tagging convention is
no longer relevant.

Signed-off-by: timflannagan <timflannagan@gmail.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. area/conformance labels Aug 22, 2024
Copy link

linux-foundation-easycla bot commented Aug 22, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot
Copy link
Contributor

Welcome @timflannagan!

It looks like this is your first PR to kubernetes-sigs/gateway-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/gateway-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @timflannagan. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Aug 22, 2024
@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 22, 2024
Signed-off-by: timflannagan <timflannagan@gmail.com>
@timflannagan
Copy link
Contributor Author

Looks like the Gloo Gateway project implementation status hasn't been updated in a while either. Just pushed up a new commit that addresses that. Happy to move that to another PR if folks have stronger opinions.

/area documentation

@k8s-ci-robot
Copy link
Contributor

@timflannagan: The label(s) area/documentation cannot be applied, because the repository doesn't have them.

In response to this:

Looks like the Gloo Gateway project implementation status hasn't been updated in a while either. Just pushed up a new commit that addresses that. Happy to move that to another PR if folks have stronger opinions.

/area documentation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mikemorris
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 22, 2024
@robscott
Copy link
Member

Thanks @timflannagan!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 23, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: robscott, timflannagan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2024
@k8s-ci-robot k8s-ci-robot merged commit bcc3161 into kubernetes-sigs:main Aug 23, 2024
8 checks passed
@timflannagan timflannagan deleted the chore/update-gloo-gateway-conformance-reports branch August 24, 2024 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants