chore: golangci.yml update #3317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mlavacca The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
|
/retest |
mlavacca
force-pushed
the
update-golangci
branch
from
0dc78d2
to
6515143
Compare
Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
mlavacca
force-pushed
the
update-golangci
branch
from
6515143
to
28c3d08
Compare
k8s-ci-robot
added
size/M
aliasing in for loops no longer needed as per https://go.dev/blog/loopvar-preview Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
mlavacca
force-pushed
the
update-golangci
branch
from
7112d14
to
d67ca90
Compare
|
Thanks @mlavacca! /lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
golangci.yml has been updated to fix some deprecations and legacy settings.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: