Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

list all installed images via kind load docker-image #2425

Closed
developer-guy opened this issue Aug 19, 2021 · 10 comments
Closed

list all installed images via kind load docker-image #2425

developer-guy opened this issue Aug 19, 2021 · 10 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@developer-guy
Copy link

What would you like to be added:

I would like to add a new subcommand like list load-images that will help us to list all installed docker images via the command kind load docker-image and this will also help us to check whether the image is loaded successfully or not.

$ kind load docker-image docker.io/librar/alpine:latest
Image: "docker.io/library/alpine:latest" with ID "sha256:021b3423115ff662225e83d7e2606475217de7b55fde83ce3447a54019a77aa2" found to be already present on all nodes.
$ kind list load-images
IMAGE                                           ID
docker.io/library/alpine:latest     sha256:021b3423115ff662225e83d7e2606475217de7b55fde83ce3447a54019a77aa2

Why is this needed:

It provides better control over checking whether the image is loaded successfully or not.

cc: @Dentrax

@developer-guy developer-guy added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 19, 2021
@developer-guy
Copy link
Author

we (w/@Dentrax) are the volunteers for doing this issue btw, we opened an issue to discuss and get ideas from maintainers 🤝🙋🏻‍♂️

@BenTheElder
Copy link
Member

How will you handle the case of multi-node clusters?

I think the idea is OK, but, it needs some thought for things like this.

Also FWIW you can use e.g. kubectl get no -o yaml to see what images kubernetes lists.

@BenTheElder
Copy link
Member

Regarding the labeling approach #2429

  • what happens if an image was imported at one point but then later pulled?

Regarding the core concept:

  • what is the use case where this is necessary? It seems like the exit code of kind load docker-image should tell you if the image was loaded successfully, barring bugs (which we should fix if they exist).

We prefer to add complexity where necessary and keep things very simple otherwise. I'm not sure if this feature is warranted or not.

Appreciate the enthusiasm and contributions in any case! ❤️

Sorry for the delay, I know aojea amwat and myself have been a little less available at the moment.

@aojea
Copy link
Contributor

aojea commented Aug 26, 2021

Also FWIW you can use e.g. kubectl get no -o yaml to see what images kubernetes lists.

@developer-guy can you explain why is preferred to use kind commands instead of the kubectl ones?

I don't adding duplicate functionality because it can diverge in the future and will be hard to maintain, is there any case kubectl doesn't cover?

@Dentrax
Copy link

Dentrax commented Feb 9, 2022

Kindly ping here. 🤞 @developer-guy @BenTheElder

It would be great to get local images before passing it to kind create cluster --image <IMAGE> command.

$ kind get images or $ kind list images would fine:

kindest/node:v1.23.0
kindest/node:v1.22.0

I can pass these to create cluster command eventually.

@BenTheElder
Copy link
Member

@Dentrax that's not what this issue was filed about / previously discussing, this was discussing kind load ...

What you are discussing with listing node images sounds like an entirely different feature request, or else a variation on one of the other multiple existing issues about node images #2114 #2376

@Dentrax
Copy link

Dentrax commented Feb 10, 2022

Oh, confused here, thanks!

Really looking forward to both kind list load-images and kind list kind-images sub commands. We can ready to give a hand on this. 🙏 @developer-guy

@BenTheElder
Copy link
Member

Outstanding questions unanswered for a year+ #2429 (comment), #2425 (comment), #2425 (comment), #2425 (comment)

And limited to no demand, so closing for now. Thanks anyhow!

@jglick
Copy link

jglick commented Apr 19, 2023

@BenTheElder FYI, for clarity GitHub now allows you to close an issue as not planned rather than completed, so for example it will show up in grey rather than purple in queries.

@BenTheElder
Copy link
Member

Thanks.

However given all of the old issues that exist and no reasonable way to change that state on old issues and no "feature" type built in I'm not convinced it's a very meaningful addition / worth the cognitive overhead. To know if a feature was implemented you still have to check the discussion or docs / current usage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
5 participants