-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow decrease reclaimable pods to 0 for suspended job #1277
Allow decrease reclaimable pods to 0 for suspended job #1277
Conversation
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hi @yaroslava-serdiuk. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @mimowo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/assign @alculquicondor
pkg/webhooks/workload_webhook.go
Outdated
@@ -388,14 +388,17 @@ func validateReclaimablePodsUpdate(newObj, oldObj *kueue.Workload, basePath *fie | |||
for i := range newObj.Status.ReclaimablePods { | |||
newCount := &newObj.Status.ReclaimablePods[i] | |||
newNames.Insert(newCount.Name) | |||
if !workload.HasQuotaReservation(newObj) && newCount.Count == 0{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if !workload.HasQuotaReservation(newObj) && newCount.Count == 0{ | |
if !workload.HasQuotaReservation(newObj) && newCount.Count == 0 { |
LGTM label has been added. Git tree hash: fa8730c34f45c3f3fc9ab0650ac940fa5454f915
|
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, yaroslava-serdiuk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
c42e82e
to
5ae1988
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 75b2c10c5e951b536292c083aaa5d03ee9b393d2
|
/kind api-change |
@alculquicondor As I can see, we change only webhooks. Is changing webhooks included in |
Yeah, a change in the validation is an API change |
What type of PR is this?
/kind feature
Which issue(s) this PR fixes:
Fixes #1215
Special notes for your reviewer:
Does this PR introduce a user-facing change?