-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Record events when QuotaReservation and Admition take place. #1436
Conversation
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
/hold For #1428 to merge, it uses that same test event recorder. |
70cdf8a
to
0d2ff3e
Compare
/retest |
0d2ff3e
to
a5a3e5c
Compare
/unhold |
/cc @alculquicondor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, trasc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, just a couple of nits
/label tide/merge-method-squash |
LGTM label has been added. Git tree hash: 14df760793c2eae53a56cd575d8dbf937ad066d1
|
/kind bug /release-note-edit
|
@alculquicondor: once the present PR merges, I will cherry-pick it on top of release-0.5 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
@alculquicondor: #1436 failed to apply on top of branch "release-0.5":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/reopen |
@alculquicondor: Failed to re-open PR: state cannot be changed. The pull request cannot be reopened. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…tes-sigs#1436) * Use different events for QuotaReservation and Admission * Review Remarks * Review Remarks * Review Remarks
What type of PR is this?
/kind feature
What this PR does / why we need it:
Record different events when QuotaReservation and Admition take place.
Which issue(s) this PR fixes:
Fixes #1392
Special notes for your reviewer:
Does this PR introduce a user-facing change?