-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not default to suspending a job whose parent is already managed by Kueue #1846
Conversation
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
/remove-kind regression |
@astefanutti Could you update a release note? |
@tenzen-y I wasn't sure what's your convention here. I think that's a regression that has only been introduced in main at the moment, is it still relevant to mention it in the release notes? |
Oh, I didn't find that. So, I'm ok with not having any release notes. Thanks! |
2d0c2ba
to
1e7a6c0
Compare
/retitle Do not default to suspending a job whose parent is already managed by Kueue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
@tenzen-y anything to add? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally, lgtm
This error could happen in the case of MPIJob (MPIJob uses batch/v1 Job) as well.
Thank you!
I left some nit comments to improve visibility.
test/integration/controller/jobs/raycluster/raycluster_webhook_test.go
Outdated
Show resolved
Hide resolved
test/integration/controller/jobs/raycluster/raycluster_webhook_test.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
/lgtm
/approve
LGTM label has been added. Git tree hash: 26c46fae6b89aaee5d555b4dfe31c52a2ce0d208
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, astefanutti, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
… Kueue (kubernetes-sigs#1846) * Do not default to suspending a job whose parent is already managed by Kueue * Better test assertions
What type of PR is this?
/kind regression
Which issue(s) this PR fixes:
Fixes #1844
This is a regression introduced in #1747.
Special notes for your reviewer:
Does this PR introduce a user-facing change?