-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow configuration of ipFamilyPolicy #1933
allow configuration of ipFamilyPolicy #1933
Conversation
Signed-off-by: dongjiang1989 <dongjiang1989@126.com>
Welcome @dongjiang1989! |
Hi @dongjiang1989. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
/ok-to-test |
@dongjiang1989: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
@dongjiang1989 the verify fails because You can run |
Signed-off-by: dongjiang1989 <dongjiang1989@126.com>
Thanks. Fixed it. Please recheck @trasc |
Signed-off-by: dongjiang1989 <dongjiang1989@126.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Leave lgtm on @trasc.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dongjiang1989, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/release-note-edit
|
Oops, this is actually user facing. /release-note-edit
|
/remove-kind documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 084b36e3539f544b10cac8caffa081f9be2009bd
|
* add ip dualstack Signed-off-by: dongjiang1989 <dongjiang1989@126.com> * fix make verify Signed-off-by: dongjiang1989 <dongjiang1989@126.com> * fix by code review Signed-off-by: dongjiang1989 <dongjiang1989@126.com> --------- Signed-off-by: dongjiang1989 <dongjiang1989@126.com>
/release-note-edit
|
What type of PR is this?
/kind documentation
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
add support allow configuration of
ipFamilyPolicy
for ipDualStack kubernetes clusterDoes this PR introduce a user-facing change?