Add create clusterqueue command #2201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
k8s-ci-robot
added
release-note
k8s-ci-robot
added
cncf-cla: yes
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
|
/test all |
IrvingMg
force-pushed
the
feature/kueuectl-create-clusterqueue
branch
from
5cf6b77
to
befd007
Compare
|
/test all |
|
/assign |
mbobrovskyi
reviewed
May 15, 2024
trasc
reviewed
May 15, 2024
k8s-ci-robot
added
size/XXL
|
/test all |
|
/test pull-kueue-test-integration-main |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 34a8eec2e5c5f3d01ef9e6a709b008e4c87f1f59
|
|
I'll leave the LGTM to @mwielgus |
|
/retest |
1 similar comment
|
/retest |
|
One review was done by @mwielgus in the past and all the points ware addressed. We can have a follow-up if something is still missing. /approve |
|
/hold for comments leave lgtm on @trasc |
k8s-ci-robot
added
do-not-merge/hold
k8s-ci-robot
removed
the
lgtm
|
Thanks! |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 20b02b1124d646a2840d027acca31de89522e794
|
k8s-ci-robot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, IrvingMg, tenzen-y, trasc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fiona-Waters
pushed a commit
to Fiona-Waters/kueue
that referenced
this pull request
Jun 25, 2024
* Add create clusterqueue command * Use ClientGetter from utils * Add unit tests for resource quotas parsing * Use flavorQuota wrapper for testing * Fix test case for unordered resources list * Validate resource groups * Validate quota params * Use Map function to cast slice * Make command usage message consistent with examples * Allow some special chars in resource name * Update create command examples * Replace error creation * Change validate method visibility
|
/release-note-edit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adds
kueuectl create clusterqueuecommand.Which issue(s) this PR fixes:
Fixes #2113
Special notes for your reviewer:
Does this PR introduce a user-facing change?