-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add limit to the retry period for re-queing workloads #2264
Add limit to the retry period for re-queing workloads #2264
Conversation
Skipping CI for Draft Pull Request. |
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
bf5b664
to
9bb27b8
Compare
/test all |
/assign @trasc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: b4345fdf2b72f1ca8a0baf6331ee4f4525652461
|
b7acd9f
to
ce6ef21
Compare
ce6ef21
to
373bc17
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, IrvingMg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost lgtm, one pending comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks
LGTM label has been added. Git tree hash: 03c1845c1a7e52d4bd5cea9e67647c800f3b8142
|
/unhold |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adds the
BackoffMaxSeconds
property to RequeuingStrategy so that a limit can be set to the retry period.Which issue(s) this PR fixes:
Fixes #2216
Special notes for your reviewer:
Does this PR introduce a user-facing change?