-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[provisionong-AC] Check the limits for used resources. #2286
[provisionong-AC] Check the limits for used resources. #2286
Conversation
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
/lgtm |
LGTM label has been added. Git tree hash: 1999da23c626f47faf8ecc2d775bed0d6aaf5112
|
I just verified that this is not enough. Please also add the logic of requests=limits when creating the PodTemplates. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, trasc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
done |
/hold cancel |
LGTM label has been added. Git tree hash: 1f9378893b7bfc9140c554c9fd5a45be1f1e24c8
|
/cherry-pick release-0.6 |
@alculquicondor: once the present PR merges, I will cherry-pick it on top of release-0.6 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@alculquicondor: new pull request created: #2293 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/release-note-edit
|
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #2278
Special notes for your reviewer:
Check the containers limits for used resources in provisioning admission check controller.
Does this PR introduce a user-facing change?