Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[kueuectl] Support paging on kueue CLI list commands. #2313

Merged
merged 1 commit into from
Jun 4, 2024
Merged

[kueuectl] Support paging on kueue CLI list commands. #2313

merged 1 commit into from
Jun 4, 2024

Conversation

mbobrovskyi
Copy link
Contributor

@mbobrovskyi mbobrovskyi commented May 29, 2024 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

Support paging on kueue CLI list commands.

Which issue(s) this PR fixes:

Fixes #2183

Special notes for your reviewer:

Does this PR introduce a user-facing change?

CLI: Support paging on kueue CLI list commands.

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 29, 2024
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label May 29, 2024
@netlify Netlify
Copy link

netlify bot commented May 29, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit a2ea4e3
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/665ea6612155fc00087fbd62

@mbobrovskyi
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 29, 2024
@mbobrovskyi mbobrovskyi mentioned this pull request May 29, 2024
Merged
@mbobrovskyi
Copy link
Contributor Author

/assign @trasc

@mbobrovskyi mbobrovskyi force-pushed the feat/support-paging-on-kueue-cli-list-commands branch from 4c9502c to 064b446 Compare May 29, 2024 09:08
@mbobrovskyi
Copy link
Contributor Author

/test all

@mbobrovskyi mbobrovskyi marked this pull request as ready for review May 29, 2024 14:15
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 29, 2024
@mbobrovskyi
Copy link
Contributor Author

/cc @IrvingMg @vladikkuzn

@mbobrovskyi
Copy link
Contributor Author

/assign @alculquicondor

alculquicondor
alculquicondor reviewed Jun 3, 2024
View reviewed changes
cmd/kueuectl/app/list/list_clusterqueue.go Outdated Show resolved Hide resolved
cmd/kueuectl/app/list/list_clusterqueue.go Outdated Show resolved Hide resolved
cmd/kueuectl/app/list/list_clusterqueue.go Show resolved Hide resolved
cmd/kueuectl/app/list/list_localqueue.go Outdated Show resolved Hide resolved
@mbobrovskyi mbobrovskyi force-pushed the feat/support-paging-on-kueue-cli-list-commands branch from 064b446 to a2ea4e3 Compare June 4, 2024 05:30
alculquicondor
alculquicondor reviewed Jun 4, 2024
View reviewed changes
Copy link
Contributor

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 4, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 48ce60624866aa4514617fdcd306aa2de0ac824d

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, mbobrovskyi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 4, 2024
@k8s-ci-robot k8s-ci-robot merged commit 80afbbf into kubernetes-sigs:main Jun 4, 2024
16 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.8 milestone Jun 4, 2024
@mbobrovskyi mbobrovskyi deleted the feat/support-paging-on-kueue-cli-list-commands branch June 4, 2024 13:20
@mbobrovskyi mbobrovskyi mentioned this pull request Jun 12, 2024
Closed
3 tasks
Fiona-Waters pushed a commit to Fiona-Waters/kueue that referenced this pull request Jun 25, 2024
@mbobrovskyi @Fiona-Waters
[kueuectl] Support paging on kueue CLI list commands. (kubernetes-sig…
d842598 
…s#2313)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@vladikkuzn vladikkuzn vladikkuzn left review comments

@trasc trasc Awaiting requested review from trasc

@denkensk denkensk Awaiting requested review from denkensk

@IrvingMg IrvingMg Awaiting requested review from IrvingMg

Assignees

@alculquicondor alculquicondor

@trasc trasc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v0.8
Development

Successfully merging this pull request may close these issues.

[kueuectl] Support paging on kueue CLI list commands
5 participants
@mbobrovskyi @k8s-ci-robot @alculquicondor @vladikkuzn @trasc