Provide support for ProvisioningRequest's BookingExpired condition #2445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
cncf-cla: yes
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
|
/assign @yaroslava-serdiuk |
|
please, fix the tests |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 672b58a98791f6ae8859027913fbce4da7767f21
|
k8s-ci-robot
removed
the
lgtm
PBundyra
force-pushed
the
support-booking-expired
branch
from
10ab30a
to
a4ef4c7
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: db579ea45ac6d17bbcd2a970814e4e724cd4c40b
|
|
/lgtm |
k8s-ci-robot
added
needs-rebase
PBundyra
force-pushed
the
support-booking-expired
branch
from
e41ca2a
to
2345c81
Compare
k8s-ci-robot
removed
the
needs-rebase
|
/retest |
PBundyra
force-pushed
the
support-booking-expired
branch
from
3b3727f
to
d6b5169
Compare
Co-authored-by: Yaroslava Serdiuk <yaroslava@google.com>
PBundyra
force-pushed
the
support-booking-expired
branch
from
51dff1b
to
c3e44e1
Compare
k8s-ci-robot
removed
the
needs-rebase
| g.Expect(k8sClient.Get(ctx, wlKey, &updatedWl)).To(gomega.Succeed()) | ||
|
|
||
| g.Expect(workload.IsEvictedByDeactivation(&updatedWl)).To(gomega.BeTrue(), "The workload should be evicted by deactivation") | ||
| util.ExpectEvictedWorkloadsTotalMetric(cq.Name, kueue.WorkloadEvictedByDeactivation, 1) |
There was a problem hiding this comment.
This line can be called after Eventually (again, to avoid Eventually inside Eventually)
|
/approve |
k8s-ci-robot
added
the
approved
tenzen-y
reviewed
Jul 9, 2024
Co-authored-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, PBundyra, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 40d4bf69dd56dfa928a62b0e00715cd864d1d9b9
|
|
/release-note-edit |
|
/release-note-edit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Provide support for the new ProvisioningRequest's condition
BookingExpired. When a Workload is Admitted this Condition has no effect. If Workload is still waiting for admission due to others AdmissionChecks running, then with respect to retry policy it, the Provisioning AdmissionCheck gets retried or rejected.Which issue(s) this PR fixes:
Fixes #2041
Special notes for your reviewer:
Does this PR introduce a user-facing change?