Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test case for TryNextFlavor but flavor is full #2482

Merged
merged 1 commit into from
Jul 5, 2024
Merged

Add test case for TryNextFlavor but flavor is full #2482

merged 1 commit into from
Jul 5, 2024

Conversation

alculquicondor
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Adds test case for undertested feature of flavor fungibility when whenCanBorrow and whenCanPreempt are both set to TryNextFlavor.

In the test case, it's not possible to borrow or preempt in the second flavor, but it's possible to preempt in the first flavor.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Jun 26, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 26, 2024
@netlify Netlify
Copy link

netlify bot commented Jun 26, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit bcb0a40
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/6687f9d0c49fcd0008db9ccf

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 27, 2024
@alculquicondor
Copy link
Contributor Author

/hold
I'm trying to debug a case similar to this.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 27, 2024
@alculquicondor alculquicondor force-pushed the test-fungibility branch 2 times, most recently from 7742587 to 8a11c4f Compare July 2, 2024 20:23
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 2, 2024
@alculquicondor
Copy link
Contributor Author

/hold cancel
This test case was more complex than I needed to unit test the fix in #2520

However, it's still useful for coverage :)

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 2, 2024
@alculquicondor
Copy link
Contributor Author

/assign @gabesaba

@alculquicondor
Copy link
Contributor Author

/retest

gabesaba
gabesaba reviewed Jul 5, 2024
View reviewed changes
pkg/scheduler/scheduler_test.go Outdated
}).
ResourceGroup(
*utiltesting.MakeFlavorQuotas("on-demand").
Resource(corev1.ResourceCPU, "0", "60").Obj(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: consider using ResourceQuotaWrapper

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

pkg/scheduler/scheduler_test.go Outdated
ResourceGroup(
*utiltesting.MakeFlavorQuotas("on-demand").
Resource(corev1.ResourceCPU, "30", "0").Obj(),
*utiltesting.MakeFlavorQuotas("spot").
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

pkg/scheduler/scheduler_test.go Outdated
Cohort("cohort").
ResourceGroup(
*utiltesting.MakeFlavorQuotas("on-demand").
Resource(corev1.ResourceCPU, "30", "0").Obj(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete borrowing limit?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 is not the same as not defined, but it doesn't matter for this CQ, so removed.

pkg/scheduler/scheduler_test.go
Request(corev1.ResourceCPU, "22").
Obj(),
},
deleteWorkloads: []kueue.Workload{*utiltesting.MakeWorkload("alpha2", "default").Obj()},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is deleteWorkloads testing anything useful in this case, or can we omit it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. It marks the termination of alpha2, so that the incoming workload can be admitted.

@alculquicondor
test case for TryNextFlavor but flavor is full
bcb0a40 
Change-Id: I289e632d1d21a2fe5f49b524d191bb63ecf6824c
@gabesaba
Copy link
Contributor

gabesaba commented Jul 5, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 5, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1fabedde51e32a6522c90c488933d265ccd4ee29

@gabesaba
Copy link
Contributor

gabesaba commented Jul 5, 2024

/retest

@k8s-ci-robot k8s-ci-robot merged commit 46ceaa5 into kubernetes-sigs:main Jul 5, 2024
16 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.8 milestone Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabesaba gabesaba gabesaba left review comments

@denkensk denkensk Awaiting requested review from denkensk

@trasc trasc Awaiting requested review from trasc

Assignees

@gabesaba gabesaba

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v0.8
Development

Successfully merging this pull request may close these issues.
3 participants
@alculquicondor @k8s-ci-robot @gabesaba