-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not omit weightedShare when zero #2521
Do not omit weightedShare when zero #2521
Conversation
Change-Id: I4cd73c62cf99072f82994eed4090189712ab08c6
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/cherry-pick release-0.7 |
@alculquicondor: once the present PR merges, I will cherry-pick it on top of release-0.7 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/retest |
/lgtm |
LGTM label has been added. Git tree hash: 7d848635e2de0711660052dfe85e67e79e8336c7
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, mimowo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@alculquicondor: new pull request created: #2522 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Hm, one more question, why wasn't this picked up by the tests:
|
Because that doesn't check the yaml. It checks the go types, which should parse empty as zero. |
/release-note-edit
|
What type of PR is this?
/kind bug
What this PR does / why we need it:
A zero value for weightedShare should be visible in the API, as it has the meaning that the CQ is not borrowing.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?