Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add release automation #5520

Open
wants to merge 21 commits into
base: master
Choose a base branch
from

Conversation

antoooks
Copy link
Contributor

@antoooks antoooks commented Jan 28, 2024

  • Add github workflow for kyaml, cmd/config, api, and kustomize
  • Revise script to support release automation
  • Revise gorepomod to support release automation
  • Add deprecation and other necessary comments
  • Add trim to handle CRLF upon semver.Parse()

Addresses #5449 and #5526

@k8s-ci-robot
Copy link
Contributor

This PR has multiple commits, and the default merge method is: merge.
You can request commits to be squashed using the label: tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 28, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @antoooks. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 28, 2024
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 3, 2024
@antoooks antoooks force-pushed the feat/5449-add-release-automation branch from e77082a to 8d6a252 Compare February 12, 2024 14:54
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 12, 2024
@antoooks antoooks force-pushed the feat/5449-add-release-automation branch from 4af5886 to 462f040 Compare May 29, 2024 16:03
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 29, 2024
@antoooks antoooks force-pushed the feat/5449-add-release-automation branch from 2a524de to d9a1e83 Compare May 30, 2024 16:40
@antoooks antoooks changed the title draft: 5449 add release automation 5449 add release automation May 30, 2024
@antoooks antoooks changed the title 5449 add release automation 5449: add release automation May 30, 2024
@antoooks antoooks changed the title 5449: add release automation draft: 5449: add release automation May 30, 2024
@antoooks antoooks force-pushed the feat/5449-add-release-automation branch 2 times, most recently from c0d33f5 to e90f6d8 Compare May 30, 2024 18:23
@antoooks antoooks changed the title draft: 5449: add release automation 5449: add release automation May 30, 2024
@antoooks
Copy link
Contributor Author

@koba1t this is ready for review.

However, I don't know why the last release changes and some other changes got carried over into my PR, I'm sure have rebased it correctly...

@koba1t
Copy link
Member

koba1t commented Jun 4, 2024

@antoooks

However, I don't know why the last release changes and some other changes got carried over into my PR, I'm sure have rebased it correctly...

Looks like your branch started at non non-latest commit(antoooks@f6ad718).
ex. https://github.com/antoooks/kustomize/network
Are you trying to sync the master branch on your forked kustomize repo(https://github.com/antoooks/kustomize)?

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 18, 2024
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 29, 2024
@antoooks antoooks force-pushed the feat/5449-add-release-automation branch from cf5e548 to 84fe9bc Compare June 29, 2024 12:35
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 29, 2024
@antoooks antoooks force-pushed the feat/5449-add-release-automation branch from 84fe9bc to 84d033a Compare August 7, 2024 16:08
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: antoooks
Once this PR has been reviewed and has the lgtm label, please ask for approval from koba1t. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@antoooks
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 10, 2024
@antoooks antoooks changed the title 5449: add release automation feat: add release automation Sep 10, 2024
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 13, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants