-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace deprecated command with environment file #1759
Replace deprecated command with environment file #1759
Conversation
Welcome @jongwooo! |
Hi @jongwooo. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
/ok-to-test
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jongwooo, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1759 +/- ##
=======================================
Coverage 49.12% 49.12%
=======================================
Files 71 71
Lines 6982 6982
=======================================
Hits 3430 3430
Misses 3418 3418
Partials 134 134 |
/override pull-security-profiles-operator-verify This is a known issue. |
@saschagrunert: Overrode contexts on behalf of saschagrunert: pull-security-profiles-operator-verify In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Update workflows to use environment file instead of deprecated
set-output
command.For more information, see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
I found the workflow files that use
set-output
command through the following command:AS-IS
echo "::set-output name=version::$(curl -s https://stable.release.flatcar-linux.net/amd64-usr/current/flatcar_production_vagrant.json | jq '.versions[0].version' | tr -d '".')"
TO-BE
echo "version=$(curl -s https://stable.release.flatcar-linux.net/amd64-usr/current/flatcar_production_vagrant.json | jq '.versions[0].version' | tr -d '".')" >> $GITHUB_OUTPUT
Which issue(s) this PR fixes:
Resolve #1758
Does this PR have test?
None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?