Continue provisioning deleted volumes #29
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
Related to kubernetes-csi/external-provisioner#131 |
jsafrane
force-pushed
the
provision-deletes
branch
from
db5c393
to
3c6e817
Compare
|
lgtm, but linter is complaining controller/volume.go:71:6:warning: exported type ProvisioningState should have comment or be unexported (golint) |
jsafrane
force-pushed
the
provision-deletes
branch
from
3c6e817
to
9abeb78
Compare
|
Fixed lint. Please review |
| } | ||
|
|
||
| // Prepare a claimRef to the claim early (to fail before a volume is | ||
| // provisioned) | ||
| claimRef, err := ref.GetReference(scheme.Scheme, claim) | ||
| if err != nil { | ||
| glog.Error(logOperation(operation, "unexpected error getting claim reference: %v", err)) | ||
| return nil | ||
| return ProvisioningNoChange, nil |
There was a problem hiding this comment.
Because I don't know what previous ProvisionExt() returned. I know it's very unlikely that GetReference succeeded once, ProvisionExt() returned Background and second GetReference fails, but I prefer to be on the safer side.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
…kind-cluster Create 2-node kind cluster since topology support is added to hostpath
CSI provisioner needs to return an error that means that provisioning may be in progress even when
Provision()finished.New
ProvisionerExtinterface is added that allows returning such status and provisioner controller will then continue trying to provision a volume until it either succeeds or some final error is received.All this is optional,
Provisionerinterface is intact and its behavior is the same as before.cc @msau42 @wongma7