Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow topology to be configured day 2 operation (#2362) #2412

Merged

Conversation

gnufied
Copy link
Contributor

@gnufied gnufied commented Jun 1, 2023

  • Allow topology to be configured as day2 operation

Only allow topology to be configured as day2 operation if it was not configured before.

* Allow topology to be configured as day2 operation

Only allow topology to be configured as day2 operation if
it was not configured before.

* Fix syncer code to update topology

Enable update events

* Move json-patch as an explicit dependency

* Only reset topology status on vanilla clusters

* Rename topologyFound to csiNodeTopologyFound
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 1, 2023
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 1, 2023
@divyenpatel
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jun 1, 2023
Copy link
Member

@divyenpatel divyenpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 2, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divyenpatel, gnufied

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 2, 2023
@k8s-ci-robot k8s-ci-robot merged commit 8564eec into kubernetes-sigs:release-3.0 Jun 2, 2023
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/vmware-vsphere-csi-driver that referenced this pull request Jul 19, 2023
kubernetes-sigs#2412)

* Allow topology to be configured as day2 operation

Only allow topology to be configured as day2 operation if
it was not configured before.

* Fix syncer code to update topology

Enable update events

* Move json-patch as an explicit dependency

* Only reset topology status on vanilla clusters

* Rename topologyFound to csiNodeTopologyFound
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants