Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cinder-csi-plugin] Tag volume with optional pvc/pv metadata #1492

Merged
merged 4 commits into from
Apr 29, 2021
Merged

[cinder-csi-plugin] Tag volume with optional pvc/pv metadata #1492

merged 4 commits into from
Apr 29, 2021

Conversation

databus23
Copy link
Contributor

@databus23 databus23 commented Apr 22, 2021 •
edited by lingxiankong
Loading

What this PR does / why we need it:
The external CSI provisioner optionally injects metadata in the CreateVolume that we can pass onto the volume as additional tags.
See kubernetes-csi/external-provisioner#399

Release note:

[cinder-csi-plugin] Support to inject PV/PVC information in Cinder volume properties.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 22, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @databus23!

It looks like this is your first PR to kubernetes/cloud-provider-openstack 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/cloud-provider-openstack has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @databus23. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 22, 2021
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 22, 2021
@databus23 databus23 changed the title [cinder-csi-plugin] Tag volume with optional metadata [cinder-csi-plugin] Tag volume with optional pvc/pv metadata Apr 22, 2021
@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 22, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 22, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 22, 2021

Build succeeded.

Fedosin
Fedosin suggested changes Apr 22, 2021
View reviewed changes
pkg/csi/cinder/controllerserver.go Outdated Show resolved Hide resolved
@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 22, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 22, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 22, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 22, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 22, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 22, 2021

Build failed.

@jichenjc
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 26, 2021
jichenjc
jichenjc reviewed Apr 26, 2021
View reviewed changes
pkg/csi/cinder/controllerserver.go
@@ -103,6 +103,12 @@ func (cs *controllerServer) CreateVolume(ctx context.Context, req *csi.CreateVol

// Volume Create
properties := map[string]string{"cinder.csi.openstack.org/cluster": cs.Driver.cluster}
//Tag volume with metadata if present: https://github.com/kubernetes-csi/external-provisioner/pull/399
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like --extraCreateMetadata is needed for such behavior to take effect ,so do we want to enable that in the mnaifest?

https://github.com/kubernetes-csi/external-provisioner/pull/399/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R68

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the flag is called --extra-create-metadata by now. I added it to the chart and the manifests.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thanks!

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 26, 2021
Fedosin
Fedosin approved these changes Apr 26, 2021
View reviewed changes
Copy link
Contributor

@Fedosin Fedosin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 26, 2021
@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 28, 2021

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.

9 similar comments
@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 28, 2021

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 28, 2021

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 28, 2021

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 28, 2021

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 28, 2021

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 28, 2021

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 28, 2021

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 28, 2021

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 28, 2021

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.

@databus23
[cinder-csi-plugin] Tag volume with optional metadata
29a196f 
The external CSI provisioner optionally injects metadata in the CreateVolume that we can pass onto the volume as additional tags.
See kubernetes-csi/external-provisioner#399

Signed-off-by: Fabian Ruff <fabian.ruff@sap.com>
@databus23
Add --extra-create-metadata to csi-provisoner manifests
c37d801 
Signed-off-by: Fabian Ruff <fabian.ruff@sap.com>
@databus23
Add unit test for extra metadata
076db8e 
Signed-off-by: Fabian Ruff <fabian.ruff@sap.com>
@databus23
Bump chart again.
0c71fb0 
Signed-off-by: Fabian Ruff <fabian.ruff@sap.com>
@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 28, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 28, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 28, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 28, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 28, 2021

Build succeeded.

@lingxiankong
Copy link
Contributor

lingxiankong commented Apr 28, 2021 •
edited
Loading

/lgtm

cc @ramineni @jichenjc please take a look, this is a nice feature to have in v1.21.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 28, 2021
@jichenjc
Copy link
Contributor

/approve

I think it's a good thing to have , thanks~

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jichenjc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2021
@lingxiankong
Copy link
Contributor

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 29, 2021
@k8s-ci-robot k8s-ci-robot merged commit 1dc67d5 into kubernetes:master Apr 29, 2021
powellchristoph pushed a commit to powellchristoph/cloud-provider-openstack that referenced this pull request Jan 19, 2022
@databus23
[cinder-csi-plugin] Tag volume with optional pvc/pv metadata (kuberne…
bed7879 
…tes#1492)

* [cinder-csi-plugin] Tag volume with optional metadata

The external CSI provisioner optionally injects metadata in the CreateVolume that we can pass onto the volume as additional tags.
See kubernetes-csi/external-provisioner#399

Signed-off-by: Fabian Ruff <fabian.ruff@sap.com>

* Add --extra-create-metadata to csi-provisoner manifests

Signed-off-by: Fabian Ruff <fabian.ruff@sap.com>

* Add unit test for extra metadata

Signed-off-by: Fabian Ruff <fabian.ruff@sap.com>

* Bump chart again.

Signed-off-by: Fabian Ruff <fabian.ruff@sap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lingxiankong lingxiankong lingxiankong requested changes

@jichenjc jichenjc jichenjc left review comments

@Fedosin Fedosin Fedosin approved these changes

@ricolin ricolin Awaiting requested review from ricolin

Assignees

@lingxiankong lingxiankong

@Fedosin Fedosin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@databus23 @k8s-ci-robot @jichenjc @lingxiankong @Fedosin