Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for etcd2 #622

Closed
spiffxp opened this issue Oct 1, 2018 · 15 comments
Closed

Drop support for etcd2 #622

spiffxp opened this issue Oct 1, 2018 · 15 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team

Comments

@spiffxp
Copy link
Member

spiffxp commented Oct 1, 2018

Feature Description

  • One-line feature description (can be used as a release note): Drop support for etcd2
  • Primary contact (assignee): @spiffxp
  • Responsible SIGs:
    • SIG API Machinery
    • SIG Release
    • SIG Testing
  • Design proposal link (community repo): n/a
  • Link to e2e and/or unit tests: n/a
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred:
    • TBD
  • Approver (likely from SIG/area to which feature belongs):
    • SIG API Machinery: @lavalamp (or whomever they would like to delegate to)
    • SIG Release: @AishSundar (or whomever they would like to delegate to)
    • SIG Testing: @spiffxp
  • Feature target (which target equals to which milestone):
    • Stable release target (1.13)

Context:

I'm filing this as a feature issue to raise visibility, but this is intended to more or less be a turning of the crank that was set in motion last year.

/sig api-machinery
/sig release
/sig testing

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Oct 1, 2018
@spiffxp
Copy link
Member Author

spiffxp commented Oct 1, 2018

/milestone v1.13

@k8s-ci-robot k8s-ci-robot added this to the v1.13 milestone Oct 1, 2018
@spiffxp
Copy link
Member Author

spiffxp commented Oct 1, 2018

/stage stable

@k8s-ci-robot k8s-ci-robot added the stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status label Oct 1, 2018
@kacole2
Copy link

kacole2 commented Oct 1, 2018

this has been added to the 1.13 tracking sheet. thanks!

@AishSundar
Copy link

@spiffxp should we call this /kind feature considering its scope?

@justaugustus
Copy link
Member

Yep.
/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 3, 2018
@justaugustus
Copy link
Member

Also, we need a SIG Release owner for this who isn't you, Aish. I think you'll be sufficiently busy with running the release. Maybe @tpepper or @dims ?

@dims
Copy link
Member

dims commented Oct 3, 2018

Happy to chip in @justaugustus @AishSundar

@liggitt
Copy link
Member

liggitt commented Oct 4, 2018

  • test jobs have been updated
  • kops updated to use etcd3
  • etcd2 support has been removed from the apiserver

@kacole2 kacole2 added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Oct 8, 2018
@spiffxp
Copy link
Member Author

spiffxp commented Oct 8, 2018

@liggitt @wojtek-t @dims @ixdy @xiang90 following up on kubernetes/kubernetes#69310 (comment)

I think we still have some more etcd2-related code to remove:

./third_party/forked/etcd221
./third_party/forked/etcd237

These are referenced in k/k:

cluster/images/etcd/migrate/rollback_v2.go
28:	oldwal "k8s.io/kubernetes/third_party/forked/etcd221/wal"
30:	// oldwal "k8s.io/kubernetes/third_party/forked/etcd237/wal"

cluster/images/etcd/migrate/BUILD
28:        "//third_party/forked/etcd221/wal:go_default_library",

And I believe we end up publishing

gcr.io/google_containers/etcd-amd64
gcr.io/google_containers/etcd-arm
gcr.io/google_containers/etcd-arm64
gcr.io/google_containers/etcd-ppc64le
gcr.io/google_containers/etcd-s390x

@tfogo
Copy link

tfogo commented Nov 3, 2018

Hi @spiffxp! Is there anywhere in the docs we'll need to update due to this?

@AishSundar
Copy link

@spiffxp do we want to include this in docs? if so can you point us to the PR plz/

@spiffxp
Copy link
Member Author

spiffxp commented Nov 29, 2018

docs: kubernetes/website#11414

@luxas
Copy link
Member

luxas commented Dec 4, 2018

This is now done as v1.13 has been released 👍.

@luxas luxas closed this as completed Dec 4, 2018
@marpaia
Copy link
Contributor

marpaia commented Jan 14, 2019

/milestone v1.14

@k8s-ci-robot k8s-ci-robot removed this from the v1.13 milestone Jan 14, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.14 milestone Jan 14, 2019
@marpaia
Copy link
Contributor

marpaia commented Jan 14, 2019

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.14 milestone Jan 14, 2019
@kacole2 kacole2 added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
None yet
Development

No branches or pull requests

10 participants