Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

master blocking jobs should probably be on etcd3 #7602

Closed
BenTheElder opened this issue Apr 6, 2018 · 23 comments
Closed

master blocking jobs should probably be on etcd3 #7602

BenTheElder opened this issue Apr 6, 2018 · 23 comments
Assignees
Labels
area/jobs kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Milestone

Comments

@BenTheElder
Copy link
Member

BenTheElder commented Apr 6, 2018

$ cat jobs/env/ci-kubernetes-e2e-gci-gce.env
### job-env
# This list should match the list in kubernetes-pull-build-test-e2e-gce.
NUM_NODES=4
# For now explicitly test etcd v2 mode in this suite.
STORAGE_BACKEND=etcd2
TEST_ETCD_IMAGE=2.2.1
TEST_ETCD_VERSION=2.2.1

# Enable the PodSecurityPolicy in tests.
ENABLE_POD_SECURITY_POLICY=true

I'm not sure who decides this or exactly all which jobs should be running what, but other jobs appear to consume this env and my understanding is that kubernetes should be solidly on etcd3 now...

@BenTheElder
Copy link
Member Author

/assign @krzyzacy
please punt to whoever is appropriate to triage which version we should use

@krzyzacy
Copy link
Member

krzyzacy commented Apr 6, 2018

/sig storage
/assign @saad-ali @msau42

@k8s-ci-robot k8s-ci-robot added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label Apr 6, 2018
@ixdy
Copy link
Member

ixdy commented Apr 6, 2018

kubernetes/kubernetes#41422

cc @mml @wojtek-t @jpbetz

@krzyzacy
Copy link
Member

krzyzacy commented Apr 6, 2018

given all other jobs are on default etcd I think we'd just remove this (and use default)

@krzyzacy krzyzacy removed the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label Apr 6, 2018
@BenTheElder
Copy link
Member Author

discussed some offline, this should probably be
/sig api-machinery

@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Apr 6, 2018
@wojtek-t
Copy link
Member

wojtek-t commented Apr 9, 2018

Personally, I'm fine with removing those jobs.

But at least in theory, we still support etcd v2 (though we are in deprecation period).
So from that point of view we may be forced to still have these tests - so let's wait for @lavalamp and @jpbetz thoughts.

@BenTheElder
Copy link
Member Author

I've discussed this some more in other venues and it sounds like we need to have some etcd2 testing until 1.12, but I think our primary CI and presubmit jobs blocking on otherwise-defaults GCE e2e should actually be completely-defaults with maybe some other dedicated etcd2 testing jobs.

@BenTheElder
Copy link
Member Author

xref: #6114 (comment)

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 30, 2018
@BenTheElder
Copy link
Member Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 30, 2018
@BenTheElder
Copy link
Member Author

Per discussion today in #sig-release we will hold on this until q4
/assign
/assign @spiffxp

@spiffxp
Copy link
Member

spiffxp commented Sep 1, 2018

Other issues related to etcd2's deprecation:

We announced in v1.9 that etcd2 is being deprecated "1.13 or 1.14"

I'm not planning to unpack which of those versions it is just yet. But I will gladly push for it to be 1.13 as we get closer to it.

@spiffxp
Copy link
Member

spiffxp commented Sep 1, 2018

/kind cleanup
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Sep 1, 2018
@tpepper
Copy link
Member

tpepper commented Sep 6, 2018

Is this important longterm only?

Or given https://groups.google.com/d/topic/kubernetes-dev/jMPA4JzKiY4/discussion is this something we should be doing NOW critical urgent?

@BenTheElder
Copy link
Member Author

My understanding was that the most recent update from sig-arch stated we'd only be dropping etcd2 support fully by 1.13, at which point we'd want to drop it from testing.

@jpbetz
Copy link
Contributor

jpbetz commented Sep 6, 2018

That sounds right to me as well.

@tpepper
Copy link
Member

tpepper commented Sep 6, 2018

sgtm then

@liggitt
Copy link
Member

liggitt commented Oct 1, 2018

It's been at the top of the release notes as being deprecated and scheduled for removal in 1.13 in 1.10-1.12.

kubernetes/kubernetes#69310 is open to remove etcd2 support and cluster-lifecycle (specifically kops) is working through switching defaults to etcd3 as well.

@BenTheElder
Copy link
Member Author

yeah I've been trying to watch that, @spiffxp was talking about tackling this from the test side the other day I think :^)

@spiffxp
Copy link
Member

spiffxp commented Oct 3, 2018

Yup, just opened a first pass, I'll see if I can give it some time tomorrow

@spiffxp
Copy link
Member

spiffxp commented Oct 3, 2018

/remove-priority important-longterm
/priority important-soon
/milestone v1.13
/sig release
/sig testing

@k8s-ci-robot k8s-ci-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Oct 3, 2018
@k8s-ci-robot k8s-ci-robot added this to the v1.13 milestone Oct 3, 2018
@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Oct 3, 2018
@spiffxp
Copy link
Member

spiffxp commented Oct 8, 2018

/close
There are no more jobs that use etcd2

@k8s-ci-robot
Copy link
Contributor

@spiffxp: Closing this issue.

In response to this:

/close
There are no more jobs that use etcd2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/jobs kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Projects
None yet
Development

No branches or pull requests