BackendConfig support for user-defined request headers

[acasademont]

Would be great if BackendConfig had support for user-defined request headers as per https://cloud.google.com/load-balancing/docs/backend-service#user-defined-request-headers

[rramkumar1]

/kind feature

[rramkumar1]

/good-first-issue
/help-wanted

[k8s-ci-robot]

@rramkumar1:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue
/help-wanted

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[agadelshin]

I'll be happy to implement this feature. I'd appreciate if you give me some references to similar feature.

[agadelshin]

Never mind, I think I got the point.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[caquino]

I'm also looking for this feature to enable custom geolocation headers on the backends.

Is this something that is still being worked on?

[rramkumar1]

We had a PR to implement this (#572) by @pondohva but it seems the PR has been abandoned. Please feel free to pick it up.

[mcfedr]

Fixed in #795

[thuandt]

@mcfedr seem Google is not yet rolling this feature.

I tried with this configuration in GKE cluster v1.13.x but didn't work

kind: BackendConfig
metadata:
  namespace: default
  name: my-cdn
spec:
  # https://cloud.google.com/load-balancing/docs/user-defined-request-headers
  # https://blog.doit-intl.com/farewell-maxmind-geolocating-requests-with-google-load-balancer-for-free-7938f5adbef0
  # https://github.com/kubernetes/ingress-gce/pull/795/files
  customRequestHeaders:
    - "X-Client-Geo-Location:{client_region},{client_region_subdivision},{client_city}"
    - "X-Client-Geo-Region:{client_region_subdivision}"
    - "X-Client-Geo-LatLong:{client_city_lat_long}"
    - "CloudFront-Viewer-Country:{client_region}"
  cdn:
    enabled: true
    cachePolicy:
      includeHost: true
      includeProtocol: true
      includeQueryString: false

[rramkumar1]

@thuandt This has not been released yet on GKE. It will likely be coming in our 1.7 release. Stay tuned...

[thuandt]

@rramkumar1 Ok. Noted

I tried with above configuration in GKE (us-west1), GCP has been trigger to add new custom headers in only one backend services instead both of them so it's not worked as expected.

btw, thanks for your support :)

[mitulpanch]

any update on this?

[rramkumar1]

@mitulpanch This is now shipped as part of our 1.7 release.