-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deployment guide for GLBC in non-gcp mode. #1022
Add deployment guide for GLBC in non-gcp mode. #1022
Conversation
Hi @cxhiano. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
docs/deploy/gke/non-gcp/README.md
Outdated
@@ -0,0 +1,141 @@ | |||
# Overview | |||
|
|||
This document will deploy the self managed Ingress-GCE controller in Non-GCP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you mean non-GKE
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or something else...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eventually we'd like deploy it on a non-GCP environment like GKE On-Prem. Currently we deploy it on GCP GKE to facilitate testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a nit.
LGTM overall
docs/deploy/gke/non-gcp/README.md
Outdated
# Overview | ||
|
||
This document will deploy the self managed Ingress-GCE controller in Non-GCP | ||
mode. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This document will deploy the self managed Ingress-GCE controller running on GCP in Non-GCP
mode.
3130114
to
c3311dc
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cxhiano, freehan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.