Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typesafe composite conversion #1027

Merged
merged 2 commits into from
Feb 16, 2020
Merged

Typesafe composite conversion #1027

merged 2 commits into from
Feb 16, 2020

Conversation

bowei
Copy link
Member

@bowei bowei commented Feb 15, 2020

Make conversion to composite type safe to avoid silent bugs.

@bowei
Make converting to composite type-safe
36c82ea 
This is very easy to mess up and can fail in very unpredictable ways.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 15, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 15, 2020
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 15, 2020
@bowei
Copy link
Member Author

bowei commented Feb 15, 2020

/assign @spencerhance @freehan @rramkumar1

@k8s-ci-robot
Copy link
Contributor

@bowei: GitHub didn't allow me to assign the following users: spencerhance.

Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @spencerhance @freehan @rramkumar1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

spencerhance
spencerhance approved these changes Feb 16, 2020
View reviewed changes
Copy link
Contributor

@spencerhance spencerhance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me

@bowei bowei merged commit 22e401a into kubernetes:master Feb 16, 2020
@bowei bowei deleted the composite branch April 21, 2020 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spencerhance spencerhance spencerhance approved these changes

@freehan freehan Awaiting requested review from freehan

@MrHohn MrHohn Awaiting requested review from MrHohn

Assignees

@freehan freehan

@rramkumar1 rramkumar1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bowei @k8s-ci-robot @spencerhance @freehan @rramkumar1