Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update go dependencies to k8s v1.18.0 #1070

Merged
merged 6 commits into from
May 6, 2020
Merged

Update go dependencies to k8s v1.18.0 #1070

merged 6 commits into from
May 6, 2020

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Apr 6, 2020 •
edited
Loading

Note: not sure this can be done in several PRs due to the breaking changes in client-go.

  • Go 1.13.9 is required because of errors.Is in API machinery
  • Use clientgofix to update client-go calls
  • Sync changes from kubernetes/kubernetes/pkg/controller/service/service_controller.go
  • Simplify k8s dependency declaration to use new format (v1.18.0 instead of commits)

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 6, 2020
@aledbf aledbf force-pushed the update branch 2 times, most recently from 9b0d4d3 to 6a0997e Compare April 6, 2020 20:44
@aledbf
Copy link
Member Author

aledbf commented Apr 6, 2020

/assign @bowei

aledbf
aledbf commented Apr 6, 2020
View reviewed changes
pkg/l4/l4controller_test.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 7, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 7, 2020
@aledbf aledbf force-pushed the update branch 2 times, most recently from 19e3bea to 71ca01a Compare April 8, 2020 00:24
@bowei
Copy link
Member

bowei commented Apr 21, 2020

@prameshj can you take a look at why the tests don't pass when the validate patch is run (see the last commit in this PR)

/assign @prameshj

@aledbf aledbf force-pushed the update branch 2 times, most recently from d171360 to 27e8da3 Compare April 21, 2020 18:25
@aledbf
Copy link
Member Author

aledbf commented Apr 21, 2020

ok, I removed the last commit and now is passing

@prameshj
Copy link
Contributor

ok, I removed the last commit and now is passing

Thanks @aledbf

/assign @bowei

@prameshj prameshj removed their assignment Apr 21, 2020
@prameshj
Copy link
Contributor

l4/l4_controller_test.go changes look good to me. Since this change moved to clientgofix, we have been able to cleanup some temporary checks that were added. Thanks for cleaning this up @aledbf.

@bowei
Copy link
Member

bowei commented May 6, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 6, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, bowei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2020
@k8s-ci-robot k8s-ci-robot merged commit fdbb955 into kubernetes:master May 6, 2020
@aledbf aledbf deleted the update branch October 28, 2020 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prameshj prameshj prameshj left review comments

@bowei bowei Awaiting requested review from bowei

@rramkumar1 rramkumar1 Awaiting requested review from rramkumar1

Assignees

@bowei bowei

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aledbf @bowei @prameshj @k8s-ci-robot