-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable pruning of unknown fields for CRDs #1096
Conversation
Hi @skmatti. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
@@ -118,6 +119,9 @@ func crd(meta *CRDMeta) *apiextensionsv1beta1.CustomResourceDefinition { | |||
klog.Errorf("Error adding simple validation for %v CRD: %v", meta.kind, err) | |||
} | |||
crd.Spec.Validation = validationSpec | |||
// Drop unknown fields of a CRD resource. Note that this needs be specified | |||
// in conjunction with validation spec. | |||
crd.Spec.PreserveUnknownFields = utilpointer.BoolPtr(false) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does the validation spec need to be updated too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it does not
/approve |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bowei, skmatti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Cherrypick #1096[Enable pruning of unknown fields for CRDs] into release-1.9
/assign @rramkumar1
fixes #1055