Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for caches to sync before running node sync #1107

Merged
merged 1 commit into from
May 20, 2020

Conversation

bowei
Copy link
Member

@bowei bowei commented May 20, 2020

There can be a race condition where the queue somehow triggers
before the caches are able to sync.

Improve logging around the event for better debugging in the future.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 20, 2020
@bowei
Copy link
Member Author

bowei commented May 20, 2020

/assign @rramkumar1

@k8s-ci-robot
Copy link
Contributor

@bowei: GitHub didn't allow me to assign the following users: mixia.

Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @mixia @rramkumar1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 20, 2020
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 20, 2020
@bowei
Copy link
Member Author

bowei commented May 20, 2020

/assign @freehan

There can be a race condition where the queue somehow triggers
before the caches are able to sync.

Improve logging around the event for better debugging in the future.
@rramkumar1
Copy link
Contributor

/lgtm

@rramkumar1 rramkumar1 merged commit 9dcaa6e into kubernetes:master May 20, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 20, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, rramkumar1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bowei bowei deleted the ig-quickfix branch May 20, 2020 19:07
k8s-ci-robot added a commit that referenced this pull request May 26, 2020
Cherry Pick #1107 [Wait for caches to sync before running node sync] to release-1.9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants