Avoid unnecessary backend service update in NEG linker

[skmatti]

No description provided.

[k8s-ci-robot]

Hi @skmatti. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[freehan]

I do not think this PR is needed as this is included in the composite NEG type

ingress-gce/pkg/backends/neg_linker.go

Line 56 in 15f450f

neg, err := l.negGetter.GetNetworkEndpointGroup(negName, group.Zone, utils.GetAPIVersionFromServicePort(&sp))

[skmatti]

I do not think this PR is needed.

The issue still exists as the utility function does not consider beta features

ingress-gce/pkg/utils/serviceport.go

Lines 61 to 66 in 15f450f

	func GetAPIVersionFromServicePort(sp *ServicePort) meta.Version {
	if sp.VMIPNEGEnabled {
	// this uses VM_IP NEGS which requires alpha API
	return meta.VersionAlpha
	}
	return meta.VersionGA

[freehan]

/ok-to-test

[freehan]

LGTM from my side.

I will let @prameshj to take a final look

[prameshj]

The change looks good to me. But I am not sure how we are avoiding an unnecessary update here. I see version lookup unified and extra logging added.

[freehan]

There is an api version section in the self link.

When you get backend-service with beta API, the selfLink of its backends all contain beta. Same for NEG selfLink. So for example, when you have beta feature enabled on backend-service. NegLinker will use beta API to get backend-service and use alpha or v1 API to get NEG. Then the NEG selfLink is always different because the API version section is different. Hence the negLinker will always try to update the backend service on every sync even though it is a noop.

[freehan]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: freehan, skmatti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [freehan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[bowei]

Stuff like this needs to go into the commit message.

Otherwise people reading the code later will have no idea that this is why the change was made.

There is an api version section in the self link.

When you get backend-service with beta API, the selfLink of its backends all contain beta. Same for NEG selfLink. So for example, when you have beta feature enabled on backend-service. NegLinker will use beta API to get backend-service and use alpha or v1 API to get NEG. Then the NEG selfLink is always different because the API version section is different. Hence the negLinker will always try to update the backend service on every sync even though it is a noop.