-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create corresponding Neg CRs when NEG CRD is enabled #1172
Create corresponding Neg CRs when NEG CRD is enabled #1172
Conversation
Hi @swetharepakula. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
c5f4713
to
174a274
Compare
fdac6ae
to
ad3e0ef
Compare
/ok-to-test |
ad3e0ef
to
14cc49b
Compare
74a80fa
to
f8832e7
Compare
f8832e7
to
a907fd8
Compare
a907fd8
to
99e473d
Compare
- when EnableNegCrd flag is set, neg client is created - manager will create neg crs when creating syncers - manager will delete neg crs when deleting syncers for removed ports - manager throws errors if custom names are specified when ingress is desired or if neg crd is not enabled
99e473d
to
78b4ff1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: freehan, swetharepakula The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Controller accepts custom names and manager will create CRs per NEG when NEG CRD is enabled.
This PR is based on PR #1166