Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compute number of L4 ILBs in error and success state #1176

Merged
merged 1 commit into from
Aug 6, 2020
Merged

Compute number of L4 ILBs in error and success state #1176

merged 1 commit into from
Aug 6, 2020

Conversation

skmatti
Copy link
Contributor

@skmatti skmatti commented Jul 7, 2020

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 7, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @skmatti. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 7, 2020
@skmatti
Copy link
Contributor Author

skmatti commented Jul 10, 2020

/assign @prameshj

@bowei
Copy link
Member

bowei commented Jul 10, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 10, 2020
bowei
bowei reviewed Jul 10, 2020
View reviewed changes
pkg/loadbalancers/l4.go Outdated
// Mark the service InSuccess state as false to begin with.
// This will be updated to true if the VIP is configured successfully.
serviceState.InSuccess = false
defer func() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be very careful what uses defer, as it's behavior is somewhat non-obvious. Is there a good reason to do this using defer?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to update service state for metrics if this function returns an error. I added defer for code compactness.
Would it be better to add this line at each return statement?.

@skmatti skmatti force-pushed the ilb-metrics branch 2 times, most recently from 242d521 to 40bf2c9 Compare July 10, 2020 20:15
@prameshj
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 13, 2020
prameshj
prameshj approved these changes Jul 13, 2020
View reviewed changes
pkg/loadbalancers/l4.go Outdated Show resolved Hide resolved
pkg/metrics/metrics.go
klog.V(6).Infof("ILB Service %s has EnabledGlobalAccess: %t, EnabledCustomSubnet: %t, InSuccess: %t", key, state.EnabledGlobalAccess, state.EnabledCustomSubnet, state.InSuccess)
counts[l4ILBService]++
if !state.InSuccess {
counts[l4ILBInError]++
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be useful to expand this in the future to indicate the reason of the error. So we could have "l4ILBErrorFirewall", "l4ILBErrorBackendService" etc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add new metric features and modify service state in order to achieve that.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 14, 2020
prameshj
prameshj reviewed Aug 5, 2020
View reviewed changes
pkg/loadbalancers/l4.go Outdated
@@ -234,18 +242,17 @@ func (l *L4) EnsureInternalLoadBalancer(nodeNames []string, svc *corev1.Service)
return nil, err
}

var serviceState metrics.L4ILBServiceState
serviceState.InSuccess = true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also set the service state to false in

ingress-gce/pkg/l4/l4controller.go

Line 161 in c96b1d8

return err

It would be worth setting it in each of those error cases. Maybe we pass in a pointer to ServiceState in EnsureInternalLoadBalancer and always set it in the processServiceCreateOrUpdate function?

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 6, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 6, 2020
@prameshj
Copy link
Contributor

prameshj commented Aug 6, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 6, 2020
@freehan
Copy link
Contributor

freehan commented Aug 6, 2020

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: freehan, prameshj, skmatti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2020
@k8s-ci-robot k8s-ci-robot merged commit e356d7a into kubernetes:master Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowei bowei bowei left review comments

@prameshj prameshj prameshj approved these changes

@rramkumar1 rramkumar1 Awaiting requested review from rramkumar1

Assignees

@freehan freehan

@prameshj prameshj

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@skmatti @k8s-ci-robot @bowei @prameshj @freehan