-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert to individual secret get #1188
Conversation
Is this a general policy for secrets? |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bowei, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
it's the recommendation for controllers that are not expected to be highly privileged, see https://kubernetes.io/docs/concepts/configuration/secret/#clients-that-use-the-secret-api
This recommendation came out of discussions in sig-auth specifically around ingress controller access patterns: |
This PR:
/assign @bowei @rramkumar1