Add instructions and a tool for people who want to try out a new version of the ingress controller before it is released. #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
rramkumar1
force-pushed
the
add-glbc-canary
branch
from
99eb7a3
to
92dba4c
Compare
|
Made the modification we discussed offline. Let me know if I missed something :) |
nicksardo
reviewed
Mar 7, 2018
| # Any image is permissible as long as: | ||
| # 1. It serves a 404 page at / | ||
| # 2. It serves 200 on a /healthz endpoint | ||
| image: gcr.io/google_containers/defaultbackend:1.3 |
There was a problem hiding this comment.
k8s.gcr.io/defaultbackend:1.4
nicksardo
reviewed
Mar 7, 2018
README.md
Outdated
| @@ -14,6 +14,10 @@ Please read the [beta limitations](BETA_LIMITATIONS.md) doc to before using this | |||
| - It relies on a beta Kubernetes resource. | |||
| - The loadbalancer controller pod is not aware of your GCE quota. | |||
|
|
|||
| **If you are running a cluster on GKE and interested in being one of the first | |||
| to get a new ingress-gce release (before it is officially released), please visit | |||
There was a problem hiding this comment.
Can we phrase this differently emphasizing this is trying out alpha releases?
nicksardo
reviewed
Mar 7, 2018
deploy/README.md
Outdated
| We will explain what each of these things mean in a bit. However, you will only be interacting | ||
| with one file (script.sh). | ||
|
|
||
| **Disclaimer: Running this script could potentially be disruptive to traffic. It |
There was a problem hiding this comment.
Perhaps mention that they should not contact GKE support if there are problems with this script or controller. Running this controller is at your own risk...
nicksardo
reviewed
Mar 7, 2018
deploy/README.md
Outdated
| # Overview | ||
|
|
||
| Welcome, you are reading this because you want to run a new version of the | ||
| GCP Ingress Controller (GLBC) before anyone else on GKE! You will notice that the |
There was a problem hiding this comment.
Same comment as above. Rephrase this as trying out an alpha release. The purpose of which is to find bugs and report their existence on github.
rramkumar1
force-pushed
the
add-glbc-canary
branch
from
92dba4c
to
f129d51
Compare
freehan
reviewed
Mar 8, 2018
|
Good point @freehan. Maybe this is goes under |
rramkumar1
force-pushed
the
add-glbc-canary
branch
from
f129d51
to
e3fc407
Compare
|
SGTM. Done |
rramkumar1
force-pushed
the
add-glbc-canary
branch
from
e3fc407
to
86047a9
Compare
|
Added copyright notice to deploy/glbc/script.sh |
…on of the ingress controller before it is released.
rramkumar1
force-pushed
the
add-glbc-canary
branch
from
86047a9
to
5723efc
Compare
nicksardo
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See title
/assign @nicksardo