Support for multiple TLS certificates #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support multiple tls secrets and multiple preshared certs specified by comma-separated string Modified hash algorithm to sha256
k8s-ci-robot
added
cncf-cla: yes
|
/assign @nicksardo |
|
Any review comments on this @G-Harmon @nikhiljindal? |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
Hello. Thank you for working on this. Are there any docs on how to use it? |
|
@stevedomin I'll make sure our documentation is updated within the next couple of days. |
|
Thanks @rramkumar1, happy to give it a read through when it's live! |
|
Any progress on the docs @rramkumar1 ? |
|
Sorry for the delay. PR for docs update is at #278 |
|
Thank you so much @rramkumar1! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #142