Ensure only needed nodeports on instance group on ingress sync #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
size/XS
|
Needs change. |
k8s-ci-robot
added
the
do-not-merge/hold
MrHohn
force-pushed
the
ensure-ig-nodeports
branch
from
78971bc
to
fc93d1b
Compare
k8s-ci-robot
added
size/S
|
/hold cancel Changed to get nodeports from the given ingress. |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I might be missing something, but it seems
ensureInstanceGroupAndPorts()is already doing what we need --- ensuring given ports are included in instance group, so the change is tiny?@rramkumar1 @nicksardo