Small addition to ClusterServiceMapper interface #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
nicksardo
reviewed
Apr 19, 2018
pkg/mapper/mapper.go
Outdated
| es := make(map[string]bool) | ||
| if expectedSvcs == nil { | ||
| return es | ||
| } |
There was a problem hiding this comment.
This nil check isn't necessary.
There was a problem hiding this comment.
This could be a generic helper func: stringsToKeyMap? If there's nothing already like it in utils, throw it in there?
rramkumar1
force-pushed
the
cluster-service-mapper-refactor
branch
from
0046b4b
to
879fc03
Compare
rramkumar1
force-pushed
the
cluster-service-mapper-refactor
branch
from
879fc03
to
811a0e3
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new method to the interface. Specifically, now the list of expected services can be overwritten with a call to SetExpectedServices.
/assign @nicksardo