Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add code for building cluster client and other resources. #236

Merged
merged 1 commit into from
Apr 20, 2018
Merged

Add code for building cluster client and other resources. #236

merged 1 commit into from
Apr 20, 2018

Conversation

rramkumar1
Copy link
Contributor

This PR does a lot of things:

  1. Add a helper for creating a kubernetes client given a Cluster spec. This code is really hacky but it will suffice for now.
  2. Add a helper for doing some work when the "add" and "delete" event handlers fire for a cluster. Specifically, this creates the client, informer managers, and service mappers for each cluster.

Note: I will probably add testing for all of this code in a separate PR.

/assign @nicksardo

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 20, 2018
nicksardo
nicksardo reviewed Apr 20, 2018
View reviewed changes
pkg/mci/controller.go Outdated
}
providerConfig := c.Spec.AuthInfo.Providers[0]
// Populate config with client auth.
restConfig.AuthProvider = &clientcmd.AuthProviderConfig{providerConfig.Name, providerConfig.Config}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go vet fails because these fields are not keyed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@rramkumar1
Copy link
Contributor Author

/retest

@nicksardo
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 20, 2018
@nicksardo nicksardo merged commit d2036fb into kubernetes:mci-dev Apr 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicksardo nicksardo nicksardo left review comments

Assignees

@nicksardo nicksardo

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rramkumar1 @nicksardo @k8s-ci-robot