Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cloud ResourceID for URL parsing and generation #304

Merged
merged 1 commit into from
Jun 5, 2018

Conversation

nicksardo
Copy link
Contributor

@nicksardo nicksardo commented Jun 5, 2018

Removes the plethora of helper functions which all perform the same basic action:

  • retrieveObjectName
  • comparableGroupPath
  • getResourceNameFromLink
  • CompareLinks
  • BackendServiceComparablePath
  • retrieveName

Replacing them with a few utility functions which depend on on the cloud package.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 5, 2018
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 5, 2018
@nicksardo nicksardo force-pushed the links branch 2 times, most recently from 054072b to 9b7330b Compare June 5, 2018 21:49
@nicksardo nicksardo changed the title Use cloud ResourceID for URL parsing and generation [WIP] Use cloud ResourceID for URL parsing and generation Jun 5, 2018
@nicksardo nicksardo merged commit b36fa7f into kubernetes:master Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants