Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simple e2e test for CDN & IAP #367

Merged
merged 1 commit into from
Jun 27, 2018
Merged

Conversation

rramkumar1
Copy link
Contributor

@rramkumar1 rramkumar1 commented Jun 26, 2018

I still need to add a test to verify the state transitions

/assign @bowei


This change is Reviewable

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 26, 2018
@rramkumar1 rramkumar1 changed the title Add simple e2e test for CDN Add simple e2e test for CDN & IAP [WIP] Jun 26, 2018
@rramkumar1
Copy link
Contributor Author

/unassign @bowei

@rramkumar1
Copy link
Contributor Author

/assign @bowei

@rramkumar1 rramkumar1 changed the title Add simple e2e test for CDN & IAP [WIP] Add simple e2e test for CDN & IAP Jun 27, 2018
Copy link
Member

@MrHohn MrHohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems straight forward, don't have many comments.
/lgtm

beConfig *backendconfig.BackendConfig
}{
{
desc: "http one path w/ IAP.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

w/ no IAP?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 27, 2018
@bowei bowei merged commit 8d77274 into kubernetes:master Jun 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants