Add a negative test case for referencing not exist BackendConfig #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
size/M
|
/lgtm |
k8s-ci-robot
added
the
lgtm
rramkumar1
reviewed
Jun 28, 2018
cmd/e2e-test/backend_config_test.go
Outdated
| } | ||
|
|
||
| port80 := intstr.FromInt(80) | ||
| testIng := fuzz.NewIngressBuilder("", "ingress-1", "").DefaultBackend("service-1", port80).AddPath("test.com", "/", "service-1", port80).Build() |
There was a problem hiding this comment.
Can we stagger the builder calls rather than having it all on one line.
MrHohn
force-pushed
the
e2e-backend-config
branch
from
67667f2
to
7bc3bb5
Compare
k8s-ci-robot
removed
the
lgtm
rramkumar1
reviewed
Jun 28, 2018
cmd/e2e-test/backend_config_test.go
Outdated
|
|
||
| port80 := intstr.FromInt(80) | ||
| testIng := fuzz.NewIngressBuilder("", "ingress-1", ""). | ||
| DefaultBackend("service-1", port80). |
There was a problem hiding this comment.
Is this DefaultBackend necessary for the test? If not, can we just remove it.
There was a problem hiding this comment.
Yeah it's not necessary. Removed.
MrHohn
force-pushed
the
e2e-backend-config
branch
from
7bc3bb5
to
6b86a2f
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
Thanks! Merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test creates a set of Ingress & Service that references a not exist BackendConfig and waits for a warning event being emitted.
/assign @rramkumar1 @bowei