Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #391

Merged
merged 1 commit into from
Aug 14, 2018
Merged

Update README.md #391

merged 1 commit into from
Aug 14, 2018

Conversation

ah-cog
Copy link
Contributor

@ah-cog ah-cog commented Jul 10, 2018

The link to SSL certificate concepts was broken. I updated the link.

The link to SSL certificate concepts was broken. I updated the link.
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 10, 2018
@ah-cog
Copy link
Contributor Author

ah-cog commented Jul 10, 2018

Here's a screenshot of the page pointed to by the broken link:

image

@rramkumar1
Copy link
Contributor

@mgub Looks like you need to sign the CLA

@rramkumar1
Copy link
Contributor

@mgub Ping

@ah-cog
Copy link
Contributor Author

ah-cog commented Aug 6, 2018

@rramkumar1 Thanks for the ping. I checked out the branch locally with git fetch origin pull/391/head:patch-1, updated my credentials with git commit --amend --reset-author and tried to push the update with git push --force as outline on Step 4 in https://github.com/kubernetes/community/blob/master/CLA.md#the-contributor-license-agreement.

I get an error:

ERROR: Permission to kubernetes/ingress-gce.git denied to mgub.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

The original edit was made directly on GitHub. Any suggestions?

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 6, 2018
@rramkumar1
Copy link
Contributor

@mgub Are you sure you were pushing to your remote origin and not upstream?

@bowei
Copy link
Member

bowei commented Aug 14, 2018

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 14, 2018
@bowei bowei merged commit 3ec7acf into kubernetes:master Aug 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants