Implement security policy validator for real #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
rramkumar1
reviewed
Jul 11, 2018
pkg/fuzz/features/security_policy.go
Outdated
| case "deny(502)": | ||
| expectedCode = 502 | ||
| default: | ||
| return fuzz.CheckResponseContinue, fmt.Errorf("unregonized rule %q", policy.Rules[0].Action) |
| @@ -112,7 +112,10 @@ func ServiceMapFromIngress(ing *v1beta1.Ingress) ServiceMap { | |||
| for _, path := range rule.HTTP.Paths { | |||
| hp := HostPath{Host: rule.Host, Path: path.Path} | |||
| if _, ok := ret[hp]; !ok { | |||
| ret[hp] = &path.Backend | |||
| // Copy the value over to a new struct so that we won't be | |||
There was a problem hiding this comment.
What was the purpose for this change?
There was a problem hiding this comment.
During the test I found we are saving the same pointer for path.Backend in this for loop because path is defined in the init statement.
Ref https://golang.org/ref/spec#For_statements: "Variables declared by the init statement are re-used in each iteration."
MrHohn
force-pushed
the
security-policy-checkresponse
branch
from
50dbb92
to
9f87dd1
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR teaches security policy validator to actually check for response's status code.
/assign @rramkumar1 @bowei