Extract BackendPool interface into three 3 separate interfaces #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
rramkumar1
force-pushed
the
backend-pool-changes
branch
2 times, most recently
from
3f800c2
to
be5ea3e
Compare
|
/assign @freehan |
rramkumar1
force-pushed
the
backend-pool-changes
branch
4 times, most recently
from
12b9cf3
to
cca40ed
Compare
rramkumar1
force-pushed
the
backend-pool-changes
branch
2 times, most recently
from
78a9e0d
to
adeb109
Compare
bowei
reviewed
Aug 9, 2018
| @@ -0,0 +1,180 @@ | |||
| package backends | |||
There was a problem hiding this comment.
Fixed everywhere.
rramkumar1
force-pushed
the
backend-pool-changes
branch
3 times, most recently
from
0291d72
to
18d5abc
Compare
|
All tests are now migrated over to new interfaces. Added a new test file called integration_test.go which contains some tests carried over from the original. Those are failing so need to figure out why. |
rramkumar1
force-pushed
the
backend-pool-changes
branch
from
18d5abc
to
7e56d86
Compare
|
Update: All tests pass. |
bowei
reviewed
Aug 10, 2018
pkg/backends/backends.go
Outdated
| // will dictate whether we search for an existing legacy health check. | ||
| hcLink, err := b.ensureHealthCheck(sp, hasLegacyHC) | ||
| if err != nil { | ||
| // Implements Pool. |
pkg/backends/backends.go
Outdated
| } | ||
|
|
||
| // Delete deletes the Backend for the given port. | ||
| // Implements Pool. | ||
| func (b *Backends) Delete(name string) (err error) { |
There was a problem hiding this comment.
Can we use non-implicit err here?
There was a problem hiding this comment.
I wasn't able to get rid of it because of the defer.
pkg/backends/backends.go
Outdated
| if !oldBackends.Equal(newBackends) { | ||
| backendService.Backends = targetBackends | ||
| return b.cloud.UpdateBetaGlobalBackendService(backendService) | ||
| // Implements Pool. |
There was a problem hiding this comment.
GetLocalSnapshot implements Pool.
pkg/backends/backends.go
Outdated
| func (b *Backends) edgeHop(be *composite.BackendService, igLinks []string) error { | ||
| addIGs, err := getInstanceGroupsToAdd(be, igLinks) | ||
| // Implements Pool. | ||
| func (b *Backends) Get(name string, version meta.Version) (*composite.BackendService, error) { |
pkg/backends/backends.go
Outdated
| func (b *Backends) Status(name string) string { | ||
| backend, err := b.cloud.GetGlobalBackendService(name) | ||
| if err != nil || len(backend.Backends) == 0 { | ||
| // Implements Pool. |
pkg/backends/ig_linker.go
Outdated
| const maxRPS = 1 | ||
|
|
||
| // InstanceGroupLinker handles linking backends to InstanceGroup's. | ||
| type InstanceGroupLinker struct { |
There was a problem hiding this comment.
Fixed it for this and others as well.
pkg/backends/ig_linker.go
Outdated
| } | ||
| } | ||
|
|
||
| // Implements Link. |
pkg/backends/ig_linker.go
Outdated
| } | ||
| } | ||
|
|
||
| // We first try to create the backend with balancingMode=RATE. If this + return addIGs |
pkg/backends/integration_test.go
Outdated
| @@ -0,0 +1,210 @@ | |||
| /* | |||
| Copyright 2015 The Kubernetes Authors. | |||
rramkumar1
force-pushed
the
backend-pool-changes
branch
from
7e56d86
to
2d9cae0
Compare
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extracts the BackendPool interface into 3 separate interfaces:
This allows us to break the current BackendPool implementation up into more manageable chunks and each chunk is much more testable. Furthermore, some implementations, namely BackendPool and Syncer, can be easily reused.
/assign @bowei