Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support short names in CRD Meta. Allows for abbreviating CRD's in kubectl #463

Merged
merged 1 commit into from
Sep 4, 2018
Merged

Support short names in CRD Meta. Allows for abbreviating CRD's in kubectl #463

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions pkg/crd/crd.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,10 +102,11 @@ func crd(meta *CRDMeta) *apiextensionsv1beta1.CustomResourceDefinition {
Version: meta.version,
Scope: apiextensionsv1beta1.NamespaceScoped,
Names: apiextensionsv1beta1.CustomResourceDefinitionNames{
Kind: meta.kind,
ListKind: meta.listKind,
Plural: meta.plural,
Singular: meta.singular,
Kind: meta.kind,
ListKind: meta.listKind,
Plural: meta.plural,
Singular: meta.singular,
ShortNames: meta.shortNames,
},
},
}
Expand Down
16 changes: 9 additions & 7 deletions pkg/crd/meta.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,20 +28,22 @@ type CRDMeta struct {
listKind string
singular string
plural string
shortNames []string
typeSource string
fn common.GetOpenAPIDefinitions
}

// NewCRDMeta creates a CRDMeta type which can be passed to a CRDHandler in
// order to create/ensure a CRD.
func NewCRDMeta(groupName, version, kind, listKind, singular, plural string) *CRDMeta {
func NewCRDMeta(groupName, version, kind, listKind, singular, plural string, shortNames ...string) *CRDMeta {
return &CRDMeta{
groupName: groupName,
version: version,
kind: kind,
listKind: listKind,
singular: singular,
plural: plural,
groupName: groupName,
version: version,
kind: kind,
listKind: listKind,
singular: singular,
plural: plural,
shortNames: shortNames,
}
}

Expand Down